Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Fix perf issue during MimeTypeGuesser intialization #27359

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
6 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented May 23, 2018

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27307
License MIT
Doc PR -

introduced in #26886

image

@stof

This comment has been minimized.

Copy link
Member

stof commented May 24, 2018

@nicolas-grekas how does this compare to #27323 ?

@vudaltsov
Copy link
Contributor

vudaltsov left a comment

Yes, this PR is much simpler, thank you!

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented May 25, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit f8e7a18 into symfony:2.7 May 25, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 25, 2018

bug #27359 [HttpFoundation] Fix perf issue during MimeTypeGuesser int…
…ialization (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[HttpFoundation] Fix perf issue during MimeTypeGuesser intialization

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27307
| License       | MIT
| Doc PR        | -

introduced in #26886

![image](https://user-images.githubusercontent.com/243674/40451947-918f5358-5ee0-11e8-9f1a-cf707bf3cefa.png)

Commits
-------

f8e7a18 [HttpFoundation] Fix perf issue during MimeTypeGuesser intialization

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:guesser-fix-init branch May 25, 2018

@fabpot fabpot referenced this pull request May 26, 2018

Merged

Release v4.1.0-BETA3 #27390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.