Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpFoundation] Fix perf issue during MimeTypeGuesser intialization #27359

Merged
merged 1 commit into from
May 25, 2018
Merged

[HttpFoundation] Fix perf issue during MimeTypeGuesser intialization #27359

merged 1 commit into from
May 25, 2018

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented May 23, 2018 •
edited

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27307
License MIT
Doc PR -

introduced in #26886

image

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone May 23, 2018
@stof
Copy link
Member

stof commented May 24, 2018

@nicolas-grekas how does this compare to #27323 ?

@nicolas-grekas nicolas-grekas mentioned this pull request May 24, 2018
Closed
vudaltsov
vudaltsov approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@vudaltsov vudaltsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this PR is much simpler, thank you!

@fabpot
Copy link
Member

fabpot commented May 25, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit f8e7a18 into symfony:2.7 May 25, 2018
fabpot added a commit that referenced this pull request May 25, 2018
@fabpot
bug #27359 [HttpFoundation] Fix perf issue during MimeTypeGuesser int…
ab32125 
…ialization (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[HttpFoundation] Fix perf issue during MimeTypeGuesser intialization

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27307
| License       | MIT
| Doc PR        | -

introduced in #26886

![image](https://user-images.githubusercontent.com/243674/40451947-918f5358-5ee0-11e8-9f1a-cf707bf3cefa.png)

Commits
-------

f8e7a18 [HttpFoundation] Fix perf issue during MimeTypeGuesser intialization
This was referenced May 25, 2018
Merged
Merged
Merged
Merged
@nicolas-grekas nicolas-grekas deleted the guesser-fix-init branch May 25, 2018 15:27
@fabpot fabpot mentioned this pull request May 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vudaltsov vudaltsov vudaltsov approved these changes

Assignees
No one assigned
Labels
Bug HttpFoundation Performance Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nicolas-grekas @stof @fabpot @vudaltsov @javiereguiluz @carsonbot