[Ldap] Use shut up operator on connection errors at ldap_start_tls #28499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Sep 18, 2018
|
Thank you @debreczeniandras. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 18, 2018
…tart_tls (Andras Debreczeni) This PR was merged into the 2.8 branch. Discussion ---------- [Ldap] Use shut up operator on connection errors at ldap_start_tls | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28426 | License | MIT | Doc PR | n/a Added shut-up operator to php function `ldap_start_tls()` so connection errors are ignored. Commits ------- af54189 [Ldap] Use shut up operator on connection errors at ldap_start_tls
|
Thank you @nicolas-grekas for your inspirational speech(es) at the Croatian Web Summer Camp conference this August. (Especially about contributing to symfony.) |
This was referenced Sep 30, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added shut-up operator to php function
ldap_start_tls()so connection errors are ignored.