Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ldap] Use shut up operator on connection errors at ldap_start_tls #28499

Conversation

Projects
None yet
3 participants
@debreczeniandras
Copy link

commented Sep 18, 2018

Q A
Branch? 2.8
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28426
License MIT
Doc PR n/a

Added shut-up operator to php function ldap_start_tls() so connection errors are ignored.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

Thank you @debreczeniandras.

@nicolas-grekas nicolas-grekas merged commit af54189 into symfony:2.8 Sep 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Sep 18, 2018

bug #28499 [Ldap] Use shut up operator on connection errors at ldap_s…
…tart_tls (Andras Debreczeni)

This PR was merged into the 2.8 branch.

Discussion
----------

[Ldap] Use shut up operator on connection errors at ldap_start_tls

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28426
| License       | MIT
| Doc PR        | n/a

Added shut-up operator to php function `ldap_start_tls()` so connection errors are ignored.

Commits
-------

af54189 [Ldap] Use shut up operator on connection errors at ldap_start_tls
@debreczeniandras

This comment has been minimized.

Copy link
Author

commented Sep 18, 2018

Thank you @nicolas-grekas for your inspirational speech(es) at the Croatian Web Summer Camp conference this August. (Especially about contributing to symfony.)

This was referenced Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.