[Console] Add missing null to input values allowed types #28647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Sep 30, 2018
chalasr
force-pushed
the
input-vals-phpdoc
branch
from
805e0ad
to
85dccae
Compare
chalasr
force-pushed
the
input-vals-phpdoc
branch
from
85dccae
to
f0bc2a6
Compare
ro0NL
approved these changes
Sep 30, 2018
xabbuh
approved these changes
Sep 30, 2018
chalasr
pushed a commit
that referenced
this pull request
Oct 1, 2018
… (chalasr) This PR was merged into the 2.8 branch. Discussion ---------- [Console] Add missing null to input values allowed types | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a When switching from `mixed` in #28448 we forgot that input arguments/options are default `null` and can be set to null (e.g. when passed empty with mode `VALUE_OPTIONAL`). Spotted by @ro0NL Commits ------- f0bc2a6 [Console] Add missing null to input values allowed types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching from
mixedin #28448 we forgot that input arguments/options are defaultnulland can be set to null (e.g. when passed empty with modeVALUE_OPTIONAL).Spotted by @ro0NL