[Console] Improve input definition output for Boolean defaults #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Boolean defaults were printed as strings, which lead to true and false being printed as "1" and "", respectively. With this change, they are now printed as "true" and "false".
fabpot
added a commit
that referenced
this pull request
Dec 15, 2011
Commits ------- d5a1343 [Console] Improve input definition output for Boolean defaults Discussion ---------- [Console] Improve input definition output for Boolean defaults This addresses an annoyance I had with command help printing `(default: )` for arguments and options that default to `false`. ``` Bug fix: no Feature addition: yes Backwards compatibility break: no (documentation text/XML output is slightly changed) Symfony2 tests pass: yes ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an annoyance I had with command help printing
(default: )for arguments and options that default tofalse.