[OptionsResolver] Trigger deprecation only if the option is used #28878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2018
yceruto
force-pushed
the
trigger_deprecation
branch
4 times, most recently
from
c19026d
to
d52af6c
Compare
|
There is still a desicion to make here to complete this patch:
See example in https://github.com/symfony/symfony/pull/28860/files#diff-c6198934d4f35bc102ff362d40b71285R40 WDYT about the @ro0NL's idea? thoughts? |
yceruto
force-pushed
the
trigger_deprecation
branch
3 times, most recently
from
d57f826
to
06ca456
Compare
yceruto
force-pushed
the
trigger_deprecation
branch
2 times, most recently
from
aa247e2
to
db8a3db
Compare
yceruto
force-pushed
the
trigger_deprecation
branch
3 times, most recently
from
1b1334f
to
44870ef
Compare
looks like this is the way to go, isn't it? |
|
It should be ready now. |
ro0NL
approved these changes
Oct 22, 2018
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
Outdated
Show resolved
Hide resolved
ro0NL
approved these changes
Oct 22, 2018
yceruto
force-pushed
the
trigger_deprecation
branch
from
c47fd5f
to
6c191b7
Compare
dunglas
approved these changes
Oct 23, 2018
xabbuh
reviewed
Oct 23, 2018
yceruto
force-pushed
the
trigger_deprecation
branch
from
6c191b7
to
e955dbd
Compare
nicolas-grekas
approved these changes
Oct 23, 2018
fabpot
approved these changes
Oct 23, 2018
xabbuh
approved these changes
Oct 23, 2018
fabpot
force-pushed
the
trigger_deprecation
branch
from
e955dbd
to
1af23c9
Compare
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Oct 24, 2018
…s used (yceruto) This PR was merged into the 4.2-dev branch. Discussion ---------- [OptionsResolver] Trigger deprecation only if the option is used | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28848 | License | MIT | Doc PR | symfony/symfony-docs#10496 It's true that showing a deprecation message when the option is not used is a bit annoying and it would be heavy to get rid of it. Now, a deprecated option is triggered only when it's provided by the user or each time is being called from a lazy evaluation (except for deprecations based on the value, they're triggered only when provided by the user). Commits ------- 1af23c9 [OptionsResolver] Trigger deprecation only if the option is used
fabpot
added a commit
that referenced
this pull request
Oct 25, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [Form] Deprecate TimezoneType regions option | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #28848 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> I know i've added this option myself in 4.1, but given my recent development for #28624 i realized it's an opinionated feaure, which can/should be solved on user-side (`choice_filter/choice_loader` and/or `group_by`). - blocks translations as we dont have them (see #28831) - blocks possibility of switching to Intl zones which doesnt really have this filter feature (see #28836) ~While at it, i solved a few issues with `OptionsResolver` that is able to deprecate options as of 4.2 also.~ Fixed in #28878 - when resolved trigger the deprecation - allow to opt-out from triggering the deprecation - dont trigger deprecation for default values (only given ones) Commits ------- 5cb532d [Form] Deprecate TimezoneType regions option
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 11, 2018
…on (yceruto) This PR was merged into the master branch. Discussion ---------- [OptionsResolver] Add some notes about trigger deprecation Updates according to symfony/symfony#28878 Commits ------- bb4861b Add some notes about trigger deprecation
nicolas-grekas
added a commit
that referenced
this pull request
Jun 9, 2019
…ons::offsetGet() (nicolas-grekas) This PR was submitted for the 4.3 branch but it was merged into the 4.2 branch instead (closes #31950). Discussion ---------- [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet() | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been added by @yceruto in #28878 but it doesn't make sense to me: the interface has no concept if deprecation (`OptionsResolver` has!) Commits ------- adc7e6a [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet()
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 11, 2019
…ruto) This PR was squashed before being merged into the 4.2 branch (closes #11704). Discussion ---------- [OptionsResolver] Add note about deprecated options Missing piece related to symfony/symfony#28878 Commits ------- aaac426 [OptionsResolver] Add note about deprecated options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's true that showing a deprecation message when the option is not used is a bit annoying and it would be heavy to get rid of it.
Now, a deprecated option is triggered only when it's provided by the user or each time is being called from a lazy evaluation (except for deprecations based on the value, they're triggered only when provided by the user).