[PropertyAccessor] Fix unable to write to singular property using setter while plural adder/remover exist

[karser]

Q	A
Branch?	3.4, 4.1 and master
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#28961
License	MIT

Please take a look at the tests I added - they describe the issue. It has to do with the priorities: findAdderAndRemover('User', 'email') is called earlier than $this->isMethodAccessible('User', 'setEmail', 1)

[stof]

instead of having this if, I would have $this->assertTrue($this->propertyAccessor->isWritable($object, 'emails'). We want the property to be writable in this test (and same thing for the previous test).

and maybe we should even write without guarding the call at all (so that if the property is not writable, we get the detailed error message in the failure)

[karser]

isWritable is not a guard here but necessary condition for reproducing this issue.
isWritable internally caches the info to writePropertyCache with 3rd argument as array getWriteAccessInfo(\get_class($object), $property, array()); which is used by findAdderAndRemover.
Do you still think assertTrue is needed for isWritable?

[karser]

If I don't call isWritable - then getWriteAccessInfo will be called by writeProperty with 3rd argument as string: $this->getWriteAccessInfo(\get_class($object), $property, $value); and findAdderAndRemover will not be called

[karser]

maybe this would be better?

$this->propertyAccessor->isWritable($object, 'email'); //cache access info
$this->propertyAccessor->setValue($object, 'email', 'test@email.com');

[karser]

The error on appveyor has nothing to do with the changes I made:

There was 1 error:
1) Symfony\Component\Process\Tests\ProcessTest::testWaitUntilSpecificOutput
Symfony\Component\Process\Exception\ProcessTimedOutException: The process "c:\php\php.exe "C:\projects\symfony\src\Symfony\Component\Process\Tests/KillableProcessWithOutput.php"" exceeded the timeout of 60 seconds.

[nicolas-grekas]

thanks for the PR.
If the issue exists on 3.4, can you please rebase+retarget your PR for branch 3.4?
This will require writing it using PHP5.5 compatible code (that's why I'm commenting on this line :) )

[karser]

@nicolas-grekas I made my changes php5 compatible in a new php5 branch.
How do I rebase the branch of this PR with the php5 branch?

[nicolas-grekas]

maybe close this PR and submit a new one would be the easiest?

[karser]

I sent my changes in another PR #28966

[karser]

@nicolas-grekas but still in general, what is the correct git flow for this situation? That is, rebase and squash my changes in order to prepare for PR?

[nicolas-grekas]

rebase the branch (without creating a new one) using git rebase -i
then retarget using the "Edit" above

[nicolas-grekas]

Replaced by #28966