New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] replace any preexisting Content-Type headers #29057

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
6 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 1, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21204
License MIT
Doc PR -
@javiereguiluz

This comment has been minimized.

Member

javiereguiluz commented Nov 7, 2018

Just wondering, for Symfony Docs, if this is merged ... should we change anything? In the stand-alone component and/or when using it as part of a Symfony full-stack app? Thanks!

@stof

stof approved these changes Nov 7, 2018

@stof

This comment has been minimized.

Member

stof commented Nov 7, 2018

@javiereguiluz I don't think the doc needs any update. This is fixing a bug for a specific case.

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 7, 2018

@javiereguiluz I don't think so, this is a bug fix.

@xabbuh

xabbuh approved these changes Nov 7, 2018

@dunglas

dunglas approved these changes Nov 8, 2018

@nicolas-grekas nicolas-grekas merged commit de2ce58 into symfony:2.8 Nov 8, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 8, 2018

bug #29057 [HttpFoundation] replace any preexisting Content-Type head…
…ers (nicolas-grekas)

This PR was merged into the 2.8 branch.

Discussion
----------

[HttpFoundation] replace any preexisting Content-Type headers

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21204
| License       | MIT
| Doc PR        | -

Commits
-------

de2ce58 [HttpFoundation] replace any preexisting Content-Type headers

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:one-content-type branch Nov 8, 2018

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment