New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] fix GraphvizDumper ignoring inline definitions #29102

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 6, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Since SF3, inline definitions are first class citizen. I noticed that the GraphvizDumper does not inspect them. Here is the fix.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 6, 2018

@nicolas-grekas nicolas-grekas merged commit ebe6265 into symfony:3.4 Nov 6, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 6, 2018

bug #29102 [DI] fix GraphvizDumper ignoring inline definitions (nicol…
…as-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] fix GraphvizDumper ignoring inline definitions

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Since SF3, inline definitions are first class citizen. I noticed that the GraphvizDumper does not inspect them. Here is the fix.

Commits
-------

ebe6265 [DI] fix GraphvizDumper ignoring inline definitions
@stof

This comment has been minimized.

Member

stof commented Nov 6, 2018

The dumper also ignores the configurator of the service, while this creates a dependency between them. Do we want them to be listed ?

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix-graphviz branch Nov 6, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 6, 2018

Correct, same for the factory BTW.

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment