New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] dont track classes/interfaces used to compute autowiring error messages #29107

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 6, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29019
License MIT
Doc PR -

This will also improve DX since tracking these files is not needed at all.

@dunglas

dunglas approved these changes Nov 6, 2018

@stof

stof approved these changes Nov 6, 2018

@stof

This comment has been minimized.

Member

stof commented Nov 6, 2018

deps=high seems to be missing du to a mongodb requirement.

@nicolas-grekas nicolas-grekas merged commit 09a0c23 into symfony:3.4 Nov 6, 2018

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

nicolas-grekas added a commit that referenced this pull request Nov 6, 2018

bug #29107 [DI] dont track classes/interfaces used to compute autowir…
…ing error messages (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] dont track classes/interfaces used to compute autowiring error messages

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29019
| License       | MIT
| Doc PR        | -

This will also improve DX since tracking these files is not needed at all.

Commits
-------

09a0c23 [DI] dont track classes/interfaces used to compute autowiring error messages

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix-autow branch Nov 6, 2018

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment