Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] dont track classes/interfaces used to compute autowiring error messages #29107

Merged
merged 1 commit into from Nov 6, 2018

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29019
License MIT
Doc PR -

This will also improve DX since tracking these files is not needed at all.

@stof
Copy link
Member

stof commented Nov 6, 2018

deps=high seems to be missing du to a mongodb requirement.

@nicolas-grekas nicolas-grekas merged commit 09a0c23 into symfony:3.4 Nov 6, 2018
nicolas-grekas added a commit that referenced this pull request Nov 6, 2018
…ing error messages (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] dont track classes/interfaces used to compute autowiring error messages

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29019
| License       | MIT
| Doc PR        | -

This will also improve DX since tracking these files is not needed at all.

Commits
-------

09a0c23 [DI] dont track classes/interfaces used to compute autowiring error messages
@nicolas-grekas nicolas-grekas deleted the di-fix-autow branch November 6, 2018 17:20
@fabpot fabpot mentioned this pull request Nov 16, 2018
This was referenced Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants