New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS #29131

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
6 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 8, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Since using it is not thread safe, let's not rely on it (already done in other places.)

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 8, 2018

@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Nov 8, 2018

see also AboutCommand::getDotenvVars()

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 8, 2018

the commands don't care about thread safety: they never run in an IIS thread.

@stof

stof approved these changes Nov 8, 2018

@chalasr

chalasr approved these changes Nov 8, 2018

@dunglas

dunglas approved these changes Nov 8, 2018

@nicolas-grekas nicolas-grekas merged commit 21a909a into symfony:3.4 Nov 8, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 8, 2018

bug #29131 [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS (ni…
…colas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Since using it is not thread safe, let's not rely on it (already done in other places.)

Commits
-------

21a909a [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:dotenv-up branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment