Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PhpUnitBridge] Fix typo #29192

Merged
merged 1 commit into from Nov 13, 2018
Merged

[PhpUnitBridge] Fix typo #29192

merged 1 commit into from Nov 13, 2018

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Nov 12, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

@ro0NL ro0NL mentioned this pull request Nov 12, 2018
Merged
@fabpot
Copy link
Member

fabpot commented Nov 13, 2018

Good catch, thanks @ro0NL.

@fabpot fabpot merged commit 78e386e into symfony:2.8 Nov 13, 2018
fabpot added a commit that referenced this pull request Nov 13, 2018
@fabpot
minor #29192 [PhpUnitBridge] Fix typo (ro0NL)
19b0189 
This PR was merged into the 2.8 branch.

Discussion
----------

[PhpUnitBridge] Fix typo

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

78e386e [PhpUnitBridge] Fix typo
@ro0NL ro0NL deleted the patch-1 branch November 13, 2018 12:26
nicolas-grekas added a commit that referenced this pull request Nov 14, 2018
@nicolas-grekas
minor #29193 [WebProfilerBundle] Remove unused data attr (ro0NL)
8cc7267 
This PR was merged into the 4.2-dev branch.

Discussion
----------

[WebProfilerBundle] Remove unused data attr

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Actually spotted in #29192 when searching in master :)

The attribute is not used.

Commits
-------

7c59375 [WebProfilerBundle] Remove unused data attr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ro0NL @fabpot @xabbuh @chalasr @carsonbot