New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] make intl+icu format seamless by handling it in MessageCatalogue #29220

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 14, 2018

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29136
License MIT
Doc PR -
@gharlan

gharlan approved these changes Nov 14, 2018 edited

It fixes my issue (tested profiler and command debug:translation)
Thanks @nicolas-grekas!

@stof

stof approved these changes Nov 14, 2018

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:translation-fix branch from b3446d2 to 4b05ff6 Nov 14, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 14, 2018

Now with tests. PR ready.

@stof

This comment has been minimized.

Member

stof commented Nov 14, 2018

@nicolas-grekas wouldn't transChoice now also go look in the Intl-ICU domain, but without switching to the Intl formatter ?

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 14, 2018

It could, but that'd mean make a new feature accessible via a deprecated API. I'd prefer not allowing it. OK for you?

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 14, 2018

OH, GOT IT.
Yes. I wouldn't care :)
New format with deprecated transChoice => not supported :)

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 14, 2018

GRR. OK, fixed. Good catch @stof :)

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:translation-fix branch from 4b05ff6 to c71dfb9 Nov 14, 2018

@stof

stof approved these changes Nov 14, 2018

@nicolas-grekas nicolas-grekas merged commit c71dfb9 into symfony:master Nov 15, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 15, 2018

bug #29220 [Translation] make intl+icu format seamless by handling it…
… in MessageCatalogue (nicolas-grekas)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Translation] make intl+icu format seamless by handling it in MessageCatalogue

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29136
| License       | MIT
| Doc PR        | -

Commits
-------

c71dfb9 [Translation] make intl+icu format seamless by handling it in MessageCatalogue

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:translation-fix branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment