[Console] Fixed and completed PHPDoc #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r typos and grammatical errors
… grammatical errors
…grammatical errors
| @@ -85,7 +85,7 @@ public function __construct($name = 'UNKNOWN', $version = 'UNKNOWN') | |||
| new InputOption('--help', '-h', InputOption::VALUE_NONE, 'Display this help message.'), | |||
| new InputOption('--quiet', '-q', InputOption::VALUE_NONE, 'Do not output any message.'), | |||
| new InputOption('--verbose', '-v', InputOption::VALUE_NONE, 'Increase verbosity of messages.'), | |||
| new InputOption('--version', '-V', InputOption::VALUE_NONE, 'Display this program version.'), | |||
| new InputOption('--version', '-V', InputOption::VALUE_NONE, 'Display this application version.'), | |||
There was a problem hiding this comment.
This breaks unit tests. Can you update them accordingly?
fabpot
added a commit
that referenced
this pull request
Dec 28, 2011
Commits ------- 3f2e1b0 [Console] Updated tests to reflect the change from `program` to `application` 2b64944 [Console][Output] Fixed some minor typos and grammatical errors 96997f1 [Console][Input] Added missing PHPDoc and fixed some minor typos and grammatical errors 855b8af [Console][Helper] Added missing PHPDoc and fixed some minor typos and grammatical errors 3ad02bd [Console][Formatter] Added missing PHPDoc @throws and fixed some minor typos and grammatical errors 33e3f11 [Console] Added a missing PHPDoc and replaced `program` by `application` Discussion ---------- [Console] Fixed and completed PHPDoc Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - * Fixed minor typos and grammatical errors * Added missing PHPDoc for some methods * Added missing @throws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -