Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] bump required Twig version #29880

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 14, 2019

Q A
Branch? 4.1
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets twigphp/Twig#2810
License MIT
Doc PR

@stof
Copy link
Member

stof commented Jan 14, 2019

this requires releasing Twig first

@xabbuh
Copy link
Member Author

xabbuh commented Jan 14, 2019

The commit has already been merged into Twig's 2.x branch which is enough to make our test suite green again. But yes, Twig must have a new release before we tag a new version of the TwigBridge.

@fabpot
Copy link
Member

fabpot commented Jan 14, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 37e8ccb into symfony:3.4 Jan 14, 2019
fabpot added a commit that referenced this pull request Jan 14, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] bump required Twig version

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | twigphp/Twig#2810
| License       | MIT
| Doc PR        |

Commits
-------

37e8ccb bump required Twig version
@xabbuh xabbuh deleted the twig-2810 branch January 14, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants