[WebProfilerBundle] Add ajax request number #30130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vudaltsov
approved these changes
Feb 10, 2019
xabbuh
approved these changes
Feb 10, 2019
|
@alamirault thanks ... and congrats on your first Symfony contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Feb 11, 2019
…irault) This PR was merged into the 4.3-dev branch. Discussion ---------- [WebProfilerBundle] Add ajax request number | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30121 | License | MIT Add request number foreach ajax call in profiler.  Commits ------- 70a38cf [WebProfilerBundle] Add ajax request number
fabpot
added a commit
that referenced
this pull request
Feb 26, 2019
…(yceruto)
This PR was merged into the 4.3-dev branch.
Discussion
----------
[WebProfilerBundle] Fix row update on finish ajax request
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
```
Uncaught TypeError: Cannot read property 'setAttribute' of undefined
at finishAjaxRequest
at XMLHttpRequest.<anonymous>
```
Continuation of #30130
Commits
-------
ff9e494 Fix row update on finish ajax request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add request number foreach ajax call in profiler.
