Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add xabbuh as code owner of the Form component #30142

Merged
merged 1 commit into from
Feb 12, 2019
Merged

add xabbuh as code owner of the Form component #30142

merged 1 commit into from
Feb 12, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 11, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Feb 11, 2019
OskarStark
OskarStark reviewed Feb 11, 2019
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything from the FrameworkBundle, like lyrixx did a few lines below?

@xabbuh
Copy link
Member Author

xabbuh commented Feb 12, 2019

@OskarStark makes sense, thanks

@fabpot
Copy link
Member

fabpot commented Feb 12, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit d0ae383 into symfony:3.4 Feb 12, 2019
fabpot added a commit that referenced this pull request Feb 12, 2019
@fabpot
minor #30142 add xabbuh as code owner of the Form component (xabbuh)
e3ceb1f 
This PR was merged into the 3.4 branch.

Discussion
----------

add xabbuh as code owner of the Form component

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

d0ae383 add xabbuh as code owner of the Form component
@xabbuh xabbuh deleted the form-code-owner branch February 12, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@xabbuh @fabpot @javiereguiluz @OskarStark @ogizanagi @chalasr @carsonbot