[Messenger] Ensure an exception is thrown when the AMQP connect() does not work #30658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Messenger
Bug
and removed
Status: Needs Review
labels
weaverryan
approved these changes
Mar 23, 2019
chalasr
approved these changes
Mar 23, 2019
sroze
added a commit
that referenced
this pull request
Mar 23, 2019
…nnect() does not work (sroze) This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] Ensure an exception is thrown when the AMQP connect() does not work | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30557 | License | MIT | Doc PR | ø This `connectionCredentials` instance escaped the renaming in #30557. Commits ------- 46b9476 Ensure an exception is thrown when the AMQP connect() does not work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
connectionCredentialsinstance escaped the renaming in #30557.