[DependencyInjection] Add test asserting service with factory is not tagged #30693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
force-pushed
the
test-for-not-tagging-services-using-factories
branch
from
2aa3bcf
to
a8e9f40
Compare
nicolas-grekas
approved these changes
Mar 26, 2019
fabpot
approved these changes
Mar 27, 2019
|
Thank you @malarzm. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2019
…ctory is not tagged (malarzm) This PR was merged into the 4.2 branch. Discussion ---------- [DependencyInjection] Add test asserting service with factory is not tagged | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a I wrote a test for a scenario that was failing for me on `4.1` branch to find out it's already fixed in 4.2 (which is awesome). Since I already had a test written and couldn't really find a PR in the changelog that could have fixed my issue I figured I'll PR a test, so the behaviour I was expecting won't get broken :) EDIT: For the record, the issue in 4.1 is: `Symfony\Component\DependencyInjection\Tests\Fixtures\BarInterface` gets tagged due to `_instanceof` which results in it being handed to `Symfony\Component\DependencyInjection\Tests\Fixtures\BarFactory` via `!tagged`. In the end this results in a recursion which is not handled. Commits ------- a8e9f40 Test service with factory is not tagged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a test for a scenario that was failing for me on
4.1branch to find out it's already fixed in 4.2 (which is awesome). Since I already had a test written and couldn't really find a PR in the changelog that could have fixed my issue I figured I'll PR a test, so the behaviour I was expecting won't get broken :)EDIT: For the record, the issue in 4.1 is:
Symfony\Component\DependencyInjection\Tests\Fixtures\BarInterfacegets tagged due to_instanceofwhich results in it being handed toSymfony\Component\DependencyInjection\Tests\Fixtures\BarFactoryvia!tagged. In the end this results in a recursion which is not handled.