Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] fix resetting the COLUMN environment variable #31001

Merged
merged 1 commit into from
Apr 8, 2019
Merged

[Console] fix resetting the COLUMN environment variable #31001

merged 1 commit into from
Apr 8, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 8, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Apr 8, 2019
@xabbuh
Copy link
Member Author

xabbuh commented Apr 8, 2019 •
edited

This should make tests pass for the 4.2 branch. I have no idea why tests on 3.4 don't fail though.

On 4.2 tests fail because the COLUMN environment variable is erroneously set to the empty string which leads to the terminal width being interpreted as 0.

@xabbuh
Copy link
Member Author

xabbuh commented Apr 8, 2019

ping @greg0ire

@fabpot
Copy link
Member

fabpot commented Apr 8, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 8fb2074 into symfony:3.4 Apr 8, 2019
fabpot added a commit that referenced this pull request Apr 8, 2019
@fabpot
minor #31001 [Console] fix resetting the COLUMN environment variable …
d3eae71 
…(xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] fix resetting the COLUMN environment variable

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

8fb2074 fix resetting the COLUMN environment variable
@xabbuh xabbuh deleted the pr-30986 branch April 8, 2019 10:17
@greg0ire
Copy link
Contributor

greg0ire commented Apr 8, 2019 •
edited

Oh right, I forgot to use === false here… thanks for fixing it. 3.4 test didn't fail because there are fewer of them and they were fairly independent already. There might be issues when merging this up (COLUMNS not initialized before running the test), and adding putenv(COLUMNS=120) in ApplicationTest::testFindAlternativeExceptionMessageMultiple should fix things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@michaelcullum michaelcullum michaelcullum approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xabbuh @fabpot @greg0ire @michaelcullum @carsonbot