Remove redundant box-sizing prefixes
#31055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Apr 10, 2019
fabpot
approved these changes
Apr 10, 2019
|
Thank you @MartijnCuppens. |
fabpot
added a commit
that referenced
this pull request
Apr 10, 2019
This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes #31055). Discussion ---------- Remove redundant `box-sizing` prefixes | Q | A | ------------- | --- | Branch? | 4.2 <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | / <!-- please add some, will be required by reviewers --> | Fixed tickets | / <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | / <!-- required for new features --> The `-webkit-` and `-moz-` prefixes are redundant and Symfony is not prefixing it on other places in the file, eg: https://github.com/symfony/symfony/blob/2243bf5bc11e3908f975f92551bd869a61211999/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig#L395-L401 Not sure what branch I should target for PRs like these, just let me know if I need to change anything. Greetings, Martijn from the [Bootstrap](https://github.com/orgs/twbs/people) team Commits ------- 0cf3227 Remove redundant `box-sizing` prefixes
|
@fabpot, should I target the |
|
@MartijnCuppens Depends on the change, but bug fixes are always merged on the lowest maintained branch, so 3.4 as of today. For new features, it should be master. |
fabpot
added a commit
that referenced
this pull request
Apr 10, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Remove redundant animation prefixes | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | / <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | / <!-- required for new features --> Like #31055, a small cleanup of CSS. CSS animations can be used safely without any prefixes. Commits ------- 3655bcf Remove redundant animation prefixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-webkit-and-moz-prefixes are redundant and Symfony is not prefixing it on other places in the file, eg:symfony/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig
Lines 395 to 401 in 2243bf5
Not sure what branch I should target for PRs like these, just let me know if I need to change anything.
Greetings,
Martijn from the Bootstrap team