Made debug:container and debug:autowiring ignore starting backslash in service id
#31304
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
Outdated
Show resolved
Hide resolved
…sh in service id
fabpot
approved these changes
May 1, 2019
|
Thank you @ruudk. |
fabpot
added a commit
that referenced
this pull request
May 1, 2019
…rting backslash in service id (ruudk) This PR was merged into the 4.2 branch. Discussion ---------- Made `debug:container` and `debug:autowiring` ignore starting backslash in service id | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT When you copy a reference to a class from PHPStorm it always start the FQCN with a backslash. When you now try to search the container for this class using `bin/console debug:container "\My\Class"` it cannot find it. This PR always removes the starting backslash before searching the container to avoid this issue. Commits ------- 0945f27 Made `debug:container` and `debug:autowiring` ignore starting backslash in service id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you copy a reference to a class from PHPStorm it always start the FQCN with a backslash.
When you now try to search the container for this class using
bin/console debug:container "\My\Class"it cannot find it.This PR always removes the starting backslash before searching the container to avoid this issue.