[DependencyInjection] Added option ignore_errors: not_found for imported config files
#31310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulzarraider
force-pushed
the
config_ignore_not_found
branch
from
3d94650
to
5ab59f2
Compare
nicolas-grekas
requested changes
Apr 29, 2019
There was a problem hiding this comment.
Hi, thanks for the PR, it looks like a good idea to me.
About the implementation, I made my review into a patch, see pulzarraider#1
pulzarraider
changed the title
ignore_not_found for imported config filesignore_not_found for imported config files
pulzarraider
changed the title
ignore_not_found for imported config filesignore_not_found for imported config files
pulzarraider
force-pushed
the
config_ignore_not_found
branch
6 times, most recently
from
c7916cf
to
9c7fc7b
Compare
sstok
suggested changes
May 25, 2019
src/Symfony/Component/Routing/Loader/Configurator/RoutingConfigurator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php
Outdated
Show resolved
Hide resolved
pulzarraider
force-pushed
the
config_ignore_not_found
branch
3 times, most recently
from
6632ba8
to
8ecb133
Compare
pulzarraider
force-pushed
the
config_ignore_not_found
branch
from
8ecb133
to
ecc0e7e
Compare
pulzarraider
changed the title
ignore_not_found for imported config filesignore_not_found for imported config files
|
Thank you @nicolas-grekas, I've merged your MR and did some more small improvements. |
|
@pulzarraider If I am correct, this must now go into I already did this for the corresponding Docs-PR symfony/symfony-docs#11647 |
pulzarraider
force-pushed
the
config_ignore_not_found
branch
5 times, most recently
from
dee7d76
to
cddf68c
Compare
|
I think this feature is finished. @nicolas-grekas @stof @sstok please review it again. |
nicolas-grekas
changed the title
ignore_not_found for imported config filesignore_errors: not_found for imported config files
nicolas-grekas
force-pushed
the
config_ignore_not_found
branch
3 times, most recently
from
18c039e
to
419a9b5
Compare
nicolas-grekas
approved these changes
Nov 7, 2019
…mporting config files
nicolas-grekas
force-pushed
the
config_ignore_not_found
branch
from
419a9b5
to
e0ee01c
Compare
|
Thank you @nicolas-grekas for your changes. |
|
Thank you @pulzarraider. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 8, 2019
…_found` for imported config files (pulzarraider) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Added option `ignore_errors: not_found` for imported config files | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#11647 If someone want to add optional config file. The only available choice was to add `ignore_errors: true` option e.g. ``` imports: - { resource: parameters.yml, ignore_errors: true } ``` But this will hide all errors in imported file. We ran in many situations that broke our Symfony applications because we had a typo in this imported files. This PR introduce new possible value `not_found` for `ignore_errors` option. It can be used for optional config files like the `ignore_errors: true`, but it will ignore only the file non-existence, not the possible syntax errors inside. Usage: ``` imports: - { resource: parameters.yml, ignore_errors: not_found} ``` Commits ------- e0ee01c [DependencyInjection] Added option `ignore_errors: not_found` while importing config files
This was referenced Nov 12, 2019
Merged
Merged
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 4, 2020
…_found` for imported config files (pulzarraider) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Added option `ignore_errors: not_found` for imported config files <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Related merge request: symfony/symfony#31310 Commits ------- 0a6873d [Configuration] Add documentation about `ignore_errors: not_found` option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone want to add optional config file. The only available choice was to add
ignore_errors: trueoptione.g.
But this will hide all errors in imported file. We ran in many situations that broke our Symfony applications because we had a typo in this imported files.
This PR introduce new possible value
not_foundforignore_errorsoption. It can be used for optional config files like theignore_errors: true, but it will ignore only the file non-existence, not the possible syntax errors inside.Usage: