Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bridge/PhpUnit] Extract all the code but shebang from bin/simple-phpunit #31364

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
5 participants
@JustBlackBird
Copy link
Contributor

commented May 2, 2019

The change allow simple-phpunit to be included without #!/usr/bin/env php string outputted.

Also it's the first step to fix #27035 (the second one is to change phpunit bridge recipe).

The reason why I fix a closed issue is because PHPStorm don't want to parse output from simple-phpunit with extra shebang.

phpstorm-phpunit

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27035
License MIT
@JustBlackBird

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Not sure if I should fix code style... The code is still the same but moved to another file.

@nicolas-grekas
Copy link
Member

left a comment

Thanks, no need to care about the CS I agree.
This should be submitted on master - it's not a real bug fix. We can merge it for 4.3 IMHO.
Pleas also open a PR for the recipe so we can discuss it at the same time.

Show resolved Hide resolved src/Symfony/Bridge/PhpUnit/bin/simple-phpunit
Show resolved Hide resolved src/Symfony/Bridge/PhpUnit/bin/simple-phpunit Outdated

@JustBlackBird JustBlackBird force-pushed the JustBlackBird:issue-27035 branch from 2fbacba to d38886c May 5, 2019

@JustBlackBird JustBlackBird changed the base branch from 4.2 to master May 5, 2019

JustBlackBird added a commit to JustBlackBird/recipes that referenced this pull request May 5, 2019

@JustBlackBird

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2019

@nicolas-grekas I've changed target to master branch and open a PR for flex recipes repo: symfony/recipes#584

[Bridge/PhpUnit] Extract all the code but shebang from bin/simple-php…
…unit

The change allow `simple-phpunit` to be included without
`#!/usr/bin/env php` string outputted.

Also it's the first step to fix #27035 (the second one is to change
phpunit bridge recipe).

@JustBlackBird JustBlackBird force-pushed the JustBlackBird:issue-27035 branch from d38886c to 74a0be3 May 5, 2019

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone May 5, 2019

JustBlackBird added a commit to JustBlackBird/recipes that referenced this pull request May 5, 2019

nicolas-grekas added a commit to JustBlackBird/recipes that referenced this pull request May 5, 2019

@lyrixx

lyrixx approved these changes May 6, 2019

@fabpot

fabpot approved these changes May 6, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Thank you @JustBlackBird.

@fabpot fabpot merged commit 74a0be3 into symfony:master May 6, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

fabpot added a commit that referenced this pull request May 6, 2019

feature #31364 [Bridge/PhpUnit] Extract all the code but shebang from…
… bin/simple-phpunit (JustBlackBird)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Bridge/PhpUnit] Extract all the code but shebang from bin/simple-phpunit

The change allow `simple-phpunit` to be included without `#!/usr/bin/env php` string outputted.

Also it's the first step to fix #27035 (the second one is to change phpunit bridge recipe).

The reason why I fix a closed issue is because PHPStorm don't want to parse output from simple-phpunit with extra shebang.

![phpstorm-phpunit](https://user-images.githubusercontent.com/1167086/57097433-6c9b2a00-6d20-11e9-9979-0c2c6d24147d.png)

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27035
| License       | MIT

Commits
-------

74a0be3 [Bridge/PhpUnit] Extract all the code but shebang from bin/simple-phpunit
@JustBlackBird

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

You're welcome @fabpot !

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.