[Bridge/PhpUnit] Extract all the code but shebang from bin/simple-phpunit #31364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if I should fix code style... The code is still the same but moved to another file. |
JustBlackBird
requested review from
dunglas,
lyrixx,
sroze and
xabbuh
as code owners
JustBlackBird
added a commit
to JustBlackBird/recipes
that referenced
this pull request
May 5, 2019
This commit is a part of fix for symfony/symfony#27035 The other part is symfony/symfony#31364
|
@nicolas-grekas I've changed target to master branch and open a PR for flex recipes repo: symfony/recipes#584 |
…unit The change allow `simple-phpunit` to be included without `#!/usr/bin/env php` string outputted. Also it's the first step to fix symfony#27035 (the second one is to change phpunit bridge recipe).
nicolas-grekas
approved these changes
May 5, 2019
JustBlackBird
added a commit
to JustBlackBird/recipes
that referenced
this pull request
May 5, 2019
This commit is a part of fix for symfony/symfony#27035 The other part is symfony/symfony#31364
nicolas-grekas
pushed a commit
to JustBlackBird/recipes
that referenced
this pull request
May 5, 2019
This commit is a part of fix for symfony/symfony#27035 The other part is symfony/symfony#31364
lyrixx
approved these changes
May 6, 2019
fabpot
approved these changes
May 6, 2019
|
Thank you @JustBlackBird. |
fabpot
added a commit
that referenced
this pull request
May 6, 2019
… bin/simple-phpunit (JustBlackBird) This PR was merged into the 4.3-dev branch. Discussion ---------- [Bridge/PhpUnit] Extract all the code but shebang from bin/simple-phpunit The change allow `simple-phpunit` to be included without `#!/usr/bin/env php` string outputted. Also it's the first step to fix #27035 (the second one is to change phpunit bridge recipe). The reason why I fix a closed issue is because PHPStorm don't want to parse output from simple-phpunit with extra shebang.  | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27035 | License | MIT Commits ------- 74a0be3 [Bridge/PhpUnit] Extract all the code but shebang from bin/simple-phpunit
|
You're welcome @fabpot ! |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jun 22, 2021
…hen using simple-phpunit (Taluu) This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] fix handling the COMPOSER_BINARY env var when using simple-phpunit | Q | A | ------------- | --- | Branch? | 4.4 and next | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41774 | License | MIT Since the renaming of the simple phpunit file (from the shebang to the php file) in #31364, it looks like the change made from #36566 was lost as it seems to have been merged after. So this PR is an attempt to "restore" that functionnality, as it was considered a bug fix on 3.4 at the time. poke `@nicolas`-grekas Commits ------- 9589b52 Reapply the change to allow to set the composer binary path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change allow
simple-phpunitto be included without#!/usr/bin/env phpstring outputted.Also it's the first step to fix #27035 (the second one is to change phpunit bridge recipe).
The reason why I fix a closed issue is because PHPStorm don't want to parse output from simple-phpunit with extra shebang.