[Cache] remove deprecated PSR-16 implementations et al. #31760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
cache-cleanup
branch
from
9eed8d6
to
38a67f8
Compare
Simperfit
reviewed
May 31, 2019
| */ | ||
| public function reset() | ||
| { | ||
| $this->clear(); |
There was a problem hiding this comment.
isn't just doing the same thing as clear without the return better ?
There was a problem hiding this comment.
We must implement both: clear() for psr-6, reset() for service-contracts.
This is copy/paste from current implementations that exist in traits.
Simperfit
approved these changes
May 31, 2019
samnela
reviewed
May 31, 2019
| * | ||
| * @return \Memcached | ||
| * | ||
| * @throws \ErrorException When invalid options or servers are provided |
There was a problem hiding this comment.
throws \ErrorException or InvalidArgumentException ?
There was a problem hiding this comment.
If you found a mismatch, please submit a fix on branch 4.2. this PR is only moving code around.
There was a problem hiding this comment.
Ok, thanks for the explanation.
Tobion
approved these changes
May 31, 2019
chalasr
approved these changes
Jun 1, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Jun 2, 2019
…(nicolas-grekas) This PR was merged into the 5.0-dev branch. Discussion ---------- [Cache] remove deprecated PSR-16 implementations et al. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - \o/ (use `Psr16Cache` instead) Commits ------- 38a67f8 [Cache] remove deprecated PSR-16 implementations et al.
nicolas-grekas
added a commit
that referenced
this pull request
Jul 7, 2021
This PR was merged into the 5.2 branch. Discussion ---------- [Cache] Remove MemcachedTrait | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A This trait is not used anywhere. It had been removed once, with #31760. But it resurfaced, presumably because of a bad merge. It is flagged as ``@internal``, so I think we can safely delete it. Commits ------- 5fb4fd4 [Cache] Remove MemcachedTrait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\o/
(use
Psr16Cacheinstead)