-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.3][Enhancement][WIP] Cachebundle #3225
Conversation
@@ -0,0 +1,64 @@ | |||
DoctrineCacheBundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this readme needs to be updated, and to be converted to a rST doc in the Resources/doc/
folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
low priority !
To avoid overlap: I am working on the configuration. |
if (empty($config['id'])) { | ||
throw new \InvalidArgumentException('Service id for memcache missing'); | ||
} | ||
$service->addMethodCall('setMemcache', array(new Reference($config['id']))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should look into supporting defining memcache(d) service id's as well as part of this Bundle.
but i am afraid i am busy with PHPCR ODM stuff :-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's part of my plan which I have described in #1513 (may be not very clearly).
I plan to work on this during the coming week, any help is appreciated.
I have finally found some time to work on this. I have just pushed a quick & dirty proto to offer a preview of what this bundle could become. Ideas are welcomed, things should change often & quickly. |
->fixXmlConfig('server') | ||
->useAttributeAsKey('name') | ||
->prototype('array') | ||
->children() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong indentation for the the tree
A quickly drafted todo list |
I am not going to work on this before next week, so feel free to pick some items on the todo list to tackle them if you feel like. |
@vicb i realize this topic is on hold. however i wonder if it wouldn't make sense to make this work available somewhere standalone. either by merging your work back into LiipDoctrineCacheBundle or somewhere else. |
@lsmith77 this has been left in an intermediate state for now, not sure if is worth merging anywhere as it is (i.e. I have made changes to the config component that should be used here). |
well i see an increasing amount of people asking me about LiipDoctrineCacheBundle and one of the main missing things in the bundle is defining memcache instances |
@lsmith77 are they looking at it for Doctrine specifically, or as a general caching solution? It may make sense to have them look at the Stash bundle until things get sorted out. |
@tedivm right now its not clear what will happen only that providing some caching solution for Symfony2 is targeted for 2.2 |
Closing as there are 4 opened PR on this topic. I would prefer that we first discuss the interface and what we want before starting coding. I suggest that this discussion happens on the Symfony dev mailing-list. Also, we need to discuss what to do with the current discussion on the FIG group mailing-list. |
Bootstrap the cache bundle based on the LiipDoctrineCacheBundle with the help of @lsmith77
This is the second part required for #1513 with the CacheComponent
Todo:
Pull Requests / feedback / comments welcomed !