Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3][Enhancement][WIP] Cachebundle #3225

Closed
wants to merge 3 commits into from
Closed

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 30, 2012

Bootstrap the cache bundle based on the LiipDoctrineCacheBundle with the help of @lsmith77

This is the second part required for #1513 with the CacheComponent

Todo:

  • Add functionalities,
  • Add tests,
  • Make use of the cache component (under development),
  • Modify other Bundles to leverage this bundle,
  • Write docs

Pull Requests / feedback / comments welcomed !

@@ -0,0 +1,64 @@
DoctrineCacheBundle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this readme needs to be updated, and to be converted to a rST doc in the Resources/doc/ folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low priority !

@vicb
Copy link
Contributor Author

vicb commented Jan 30, 2012

To avoid overlap: I am working on the configuration.

if (empty($config['id'])) {
throw new \InvalidArgumentException('Service id for memcache missing');
}
$service->addMethodCall('setMemcache', array(new Reference($config['id'])));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should look into supporting defining memcache(d) service id's as well as part of this Bundle.
but i am afraid i am busy with PHPCR ODM stuff :-/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's part of my plan which I have described in #1513 (may be not very clearly).
I plan to work on this during the coming week, any help is appreciated.

@vicb vicb mentioned this pull request Feb 12, 2012
@vicb
Copy link
Contributor Author

vicb commented Feb 13, 2012

I have finally found some time to work on this. I have just pushed a quick & dirty proto to offer a preview of what this bundle could become. Ideas are welcomed, things should change often & quickly.

->fixXmlConfig('server')
->useAttributeAsKey('name')
->prototype('array')
->children()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indentation for the the tree

@vicb
Copy link
Contributor Author

vicb commented Feb 13, 2012

anybody (@stof, @dlsniper ?) feel free to submit PRs, I am done for today. I would prefer if we can discuss before breaking the current architecture but there are many things to do anyway.

In the future we can sync if anybody want to give some help, we can work on a todo list if needed.

@vicb
Copy link
Contributor Author

vicb commented Feb 14, 2012

A quickly drafted todo list

@vicb
Copy link
Contributor Author

vicb commented Feb 16, 2012

I am not going to work on this before next week, so feel free to pick some items on the todo list to tackle them if you feel like.

@lsmith77
Copy link
Contributor

@vicb i realize this topic is on hold. however i wonder if it wouldn't make sense to make this work available somewhere standalone. either by merging your work back into LiipDoctrineCacheBundle or somewhere else.

@vicb
Copy link
Contributor Author

vicb commented Apr 16, 2012

@lsmith77 this has been left in an intermediate state for now, not sure if is worth merging anywhere as it is (i.e. I have made changes to the config component that should be used here).

@lsmith77
Copy link
Contributor

well i see an increasing amount of people asking me about LiipDoctrineCacheBundle and one of the main missing things in the bundle is defining memcache instances

@tedivm
Copy link

tedivm commented Apr 16, 2012

@lsmith77 are they looking at it for Doctrine specifically, or as a general caching solution? It may make sense to have them look at the Stash bundle until things get sorted out.

@lsmith77
Copy link
Contributor

@tedivm right now its not clear what will happen only that providing some caching solution for Symfony2 is targeted for 2.2

@fabpot
Copy link
Member

fabpot commented Mar 23, 2013

Closing as there are 4 opened PR on this topic. I would prefer that we first discuss the interface and what we want before starting coding. I suggest that this discussion happens on the Symfony dev mailing-list. Also, we need to discuss what to do with the current discussion on the FIG group mailing-list.

@fabpot fabpot closed this Mar 23, 2013
@fabpot
Copy link
Member

fabpot commented Mar 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants