[Process] [5.0] Replace docblocks by type-hints #32273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 tasks
tigitz
changed the title
derrabus
requested changes
Jun 29, 2019
tigitz
changed the title
|
@derrabus @nicolas-grekas While my initial scope was to take care of new type-hintable params allowed by 5.0, I went a little bit further and took care of others type-hintable params. But fact is, these additional type-hints can already lands in 4.* IMO and be seen as a continuation of #24722. So I'll keep this PR exclusively about it's initial 5.0 scope and make another one targeting 4.* version with these additional type-hints. Sorry for the bother |
fabpot
approved these changes
Jul 5, 2019
|
Thank you @tigitz. |
fabpot
added a commit
that referenced
this pull request
Jul 5, 2019
…e Segatori, tigitz) This PR was squashed before being merged into the 5.0-dev branch (closes #32273). Discussion ---------- [Process] [5.0] Replace docblocks by type-hints | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | continuation of #24722 and checks for #32179 | License | MIT | Doc PR | N/A This PR adds replace docblocks by type hints in the Process component. Some docblocks without valuable information got also removed. Commits ------- 5c964c5 [Process] [5.0] Replace docblocks by type-hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds replace docblocks by type hints in the Process component. Some docblocks without valuable information got also removed.