Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workflow] Remove DefinitionBuilder::setInitialPlace() #32301

Merged
merged 1 commit into from Jul 1, 2019
Merged

[Workflow] Remove DefinitionBuilder::setInitialPlace() #32301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/Symfony/Component/Workflow/DefinitionBuilder.php
View file
Open in desktop
Expand Up @@ -60,22 +60,6 @@ public function clear()
return $this;
}

/**
* @deprecated since Symfony 4.3. Use setInitialPlaces() instead.
*
* @param string $place
*
* @return $this
*/
public function setInitialPlace($place)
{
@trigger_error(sprintf('Calling %s::setInitialPlace() is deprecated since Symfony 4.3. Call setInitialPlaces() instead.', __CLASS__), E_USER_DEPRECATED);

$this->initialPlaces = $place;

return $this;
}

/**
* @param string|string[]|null $initialPlaces
*
Expand Down
10 changes: 0 additions & 10 deletions src/Symfony/Component/Workflow/Tests/DefinitionBuilderTest.php
View file
Open in desktop
Expand Up @@ -9,16 +9,6 @@

class DefinitionBuilderTest extends TestCase
{
/** @group legacy */
public function testSetInitialPlace()
{
$builder = new DefinitionBuilder(['a', 'b']);
$builder->setInitialPlace('b');
$definition = $builder->build();

$this->assertEquals(['b'], $definition->getInitialPlaces());
}

public function testSetInitialPlaces()
{
$builder = new DefinitionBuilder(['a', 'b']);
Expand Down