[DomCrawler] [5.0] add type-hint whenever possible #32329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
force-pushed
the
feature/add-type-hint-to-domcrawler
branch
from
e809256
to
c8a3972
Compare
| * | ||
| * @return array The list of fields as [string] Fully qualified name => (mixed) value) | ||
| */ | ||
| private function walk(array $array, $base = '', array &$output = []) | ||
| private function walk(array $array, ?string $base = '', array &$output = []) |
There was a problem hiding this comment.
Shouldn't ?string be instead string ?
There was a problem hiding this comment.
if we don't allow null, it break lots of test:
TypeError: Argument 2 passed to Symfony\Component\DomCrawler\FormFieldRegistry::walk() must be of the type string, null given, called in /home/hamza/projet/contrib/symfony/src/Symfony/Component/DomCrawler/FormFieldRegistry.php on line 133
There was a problem hiding this comment.
So, it means that we need to ensure that $this->base cannot be null but an empty string instead. Or we need to change the calling code.
There was a problem hiding this comment.
we can set the default value of $this->base to an empty string, that's the proposal I've pushed.
stof
reviewed
Jul 3, 2019
| * | ||
| * @return array The list of fields as [string] Fully qualified name => (mixed) value) | ||
| */ | ||
| private function walk(array $array, $base = '', array &$output = []) | ||
| private function walk(array $array, ?string $base = '', array &$output = []) |
Simperfit
force-pushed
the
feature/add-type-hint-to-domcrawler
branch
from
c8a3972
to
a4ed068
Compare
57 tasks
fabpot
requested changes
Jul 5, 2019
| * | ||
| * @return array The list of fields as [string] Fully qualified name => (mixed) value) | ||
| */ | ||
| private function walk(array $array, $base = '', array &$output = []) | ||
| private function walk(array $array, ?string $base = '', array &$output = []) |
There was a problem hiding this comment.
So, it means that we need to ensure that $this->base cannot be null but an empty string instead. Or we need to change the calling code.
Simperfit
force-pushed
the
feature/add-type-hint-to-domcrawler
branch
from
a4ed068
to
580b126
Compare
|
done @fabpot |
fabpot
approved these changes
Jul 8, 2019
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2019
…erfit) This PR was merged into the 5.0-dev branch. Discussion ---------- [DomCrawler] [5.0] add type-hint whenever possible | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | Contribute to #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | none <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Add type hint to DomCrawler Commits ------- 580b126 [DomCrawler] [5.0] add type-hint whenever possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type hint to DomCrawler