Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Added more test for MessageBus #32338

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
5 participants
@lyrixx
Copy link
Member

commented Jul 3, 2019

Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This code is quite hard to understand. So It must be covered by tests.

More over, it will help people to understand how it works

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Jul 3, 2019

@fabpot

fabpot approved these changes Jul 3, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit 5f4ab23 into symfony:4.3 Jul 3, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 3, 2019

minor #32338 [Messenger] Added more test for MessageBus (lyrixx)
This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] Added more test for MessageBus

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

[This code](https://github.com/symfony/symfony/blob/bed50fd5421d56090a0073a555748767575d3b49/src/Symfony/Component/Messenger/MessageBus.php#L33-L49) is quite hard to understand. So It must be covered by tests.

More over, it will help people to understand how it works

Commits
-------

5f4ab23 [Messenger] Added more test for MessageBus

@lyrixx lyrixx deleted the lyrixx:messenger-test branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.