[Messenger] Added more test for MessageBus #32338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Jul 3, 2019
fabpot
approved these changes
Jul 3, 2019
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Added more test for MessageBus | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | [This code](https://github.com/symfony/symfony/blob/bed50fd5421d56090a0073a555748767575d3b49/src/Symfony/Component/Messenger/MessageBus.php#L33-L49) is quite hard to understand. So It must be covered by tests. More over, it will help people to understand how it works Commits ------- 5f4ab23 [Messenger] Added more test for MessageBus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is quite hard to understand. So It must be covered by tests.
More over, it will help people to understand how it works