Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpClient] add "max_duration" option #32807

Merged
merged 1 commit into from Aug 6, 2019
Merged

[HttpClient] add "max_duration" option #32807

merged 1 commit into from Aug 6, 2019

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Jul 30, 2019 •
edited

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32765
License MIT
Doc PR symfony/symfony-docs#12073

@nicolas-grekas nicolas-grekas added this to the next milestone Jul 30, 2019
@fancyweb fancyweb force-pushed the transfer-timeout branch 2 times, most recently from c5bfb73 to 85fc4fa Compare July 30, 2019 16:10
@fancyweb fancyweb changed the title [HttpClient] Transfer timeout [HttpClient] Max duration Jul 30, 2019
@fancyweb fancyweb force-pushed the transfer-timeout branch 2 times, most recently from 55c3b79 to fd5ce76 Compare July 31, 2019 08:49
@fancyweb fancyweb force-pushed the transfer-timeout branch 3 times, most recently from c45f257 to 0666c84 Compare July 31, 2019 12:06
@nicolas-grekas nicolas-grekas changed the title [HttpClient] Max duration [HttpClient] adde "max_duration" option Jul 31, 2019
@nicolas-grekas nicolas-grekas changed the title [HttpClient] adde "max_duration" option [HttpClient] add "max_duration" option Jul 31, 2019
@fancyweb fancyweb force-pushed the transfer-timeout branch 2 times, most recently from bc7bead to 6b62a10 Compare July 31, 2019 12:22
@fancyweb fancyweb mentioned this pull request Jul 31, 2019
Merged
nicolas-grekas added a commit that referenced this pull request Jul 31, 2019
@nicolas-grekas
minor #32829 [Contracts] Fix branch alias (fancyweb)
d25448c 
This PR was merged into the 4.4 branch.

Discussion
----------

[Contracts] Fix branch alias

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Spotted in #32807

Commits
-------

05cfc2b [Contracts] Fix branch alias
@nicolas-grekas
Copy link
Member

Shouldn't we allow configuring the option in frameworkbundle?

@fancyweb fancyweb force-pushed the transfer-timeout branch 2 times, most recently from 97a3aac to 37b47ed Compare August 1, 2019 13:28
@fancyweb fancyweb mentioned this pull request Aug 1, 2019
Merged
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit a4178f1 into symfony:4.4 Aug 6, 2019
nicolas-grekas added a commit that referenced this pull request Aug 6, 2019
@nicolas-grekas
feature #32807 [HttpClient] add "max_duration" option (fancyweb)
3498259 
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] add "max_duration" option

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32765
| License       | MIT
| Doc PR        | symfony/symfony-docs#12073

Commits
-------

a4178f1 [HttpClient] add "max_duration" option
@fancyweb fancyweb deleted the transfer-timeout branch August 6, 2019 08:49
@pyrech
Copy link
Contributor

pyrech commented Aug 6, 2019

Awesome! Thank you @fancyweb

OskarStark added a commit to symfony/symfony-docs that referenced this pull request Aug 15, 2019
@OskarStark
feature #12073 [FrameworkBundle][HttpClient] "max_duration" option (f…
f20dc70 
…ancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle][HttpClient] "max_duration" option

Doc for symfony/symfony#32807

Commits
-------

a0e1776 [FrameworkBundle][HttpClient] "max_duration" option
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Merged
Merged
@nicolas-grekas nicolas-grekas mentioned this pull request May 17, 2022
Merged
nicolas-grekas added a commit that referenced this pull request May 17, 2022
@nicolas-grekas
bug #46380 [HttpClient] Add missing HttpOptions::setMaxDuration() (ni…
1a7fa5d 
…colas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Add missing HttpOptions::setMaxDuration()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | no

Forgotten in #32807

Commits
-------

54d442a [HttpClient] Add missing HttpOptions::setMaxDuration()
@beberlei beberlei mentioned this pull request Aug 10, 2022
Closed
@deeky666 deeky666 mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@lyrixx lyrixx lyrixx left review comments

Assignees
No one assigned
Labels
Feature HttpClient Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fancyweb @nicolas-grekas @pyrech @lyrixx @carsonbot