[Form] update type of form $name arguments #32828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Jul 31, 2019
derrabus
approved these changes
Jul 31, 2019
vudaltsov
approved these changes
Jul 31, 2019
xabbuh
approved these changes
Jul 31, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Jul 31, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Form] update type of form $name arguments | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32821 | License | MIT | Doc PR | - An alternative to #32821: where a string is expected, passing an int is fine, per PHP casting rules. Commits ------- 6d4dcad [Form] update type of form $name arguments
fabpot
added a commit
that referenced
this pull request
Aug 5, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Form] remove leftover int child phpdoc | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | Fix leftover from #32828 Commits ------- 4cd60d6 [Form] remove leftover int child phpdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #32821: where a string is expected, passing an int is fine, per PHP casting rules.