Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable typehint patch on PHPUnit #33042

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@jderusse
Copy link
Contributor

commented Aug 8, 2019

Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32844
License MIT
Doc PR NA

This PR removes the SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT patch and adds a : void typehint on setup and tearDown methods in order to be compatible with PHPUnit 8

@jderusse jderusse requested review from lyrixx and xabbuh as code owners Aug 8, 2019

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Aug 8, 2019

@jderusse jderusse force-pushed the jderusse:compat-phpunit8 branch from 94c4fe3 to a5af6c4 Aug 8, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit a5af6c4 into symfony:4.3 Aug 8, 2019

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

nicolas-grekas added a commit that referenced this pull request Aug 8, 2019

minor #33042 Disable typehint patch on PHPUnit (jderusse)
This PR was merged into the 4.3 branch.

Discussion
----------

Disable typehint patch on PHPUnit

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32844
| License       | MIT
| Doc PR        | NA

This PR removes the `SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT` patch and adds a `: void` typehint on `setup` and `tearDown` methods in order to be compatible with PHPUnit 8

Commits
-------

a5af6c4 Disable phpunit typehint patch on 4.3 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.