Disable typehint patch on PHPUnit #33042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
compat-phpunit8
branch
from
94c4fe3
to
a5af6c4
Compare
derrabus
approved these changes
Aug 8, 2019
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Disable typehint patch on PHPUnit | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA This PR removes the `SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT` patch and adds a `: void` typehint on `setup` and `tearDown` methods in order to be compatible with PHPUnit 8 Commits ------- a5af6c4 Disable phpunit typehint patch on 4.3 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINTpatch and adds a: voidtypehint onsetupandtearDownmethods in order to be compatible with PHPUnit 8