Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility trait for PHPUnit constraint classes #33078

Merged

Conversation

@alcaeus
Copy link
Contributor

commented Aug 9, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Similar to the SetUpTearDownTrait, this trait removes the pain of dealing with method signature changes. The PHPUnit\Framework\Constraint\Constraint class added return type hints in PHPUnit 7 which this trait will take care of.

@alcaeus alcaeus force-pushed the alcaeus:phpunit-bridge-add-constraint-compat-layer branch from 183fa26 to 908c8c1 Aug 9, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Aug 9, 2019

@fabpot

fabpot approved these changes Aug 9, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Thank you @alcaeus.

@fabpot fabpot merged commit 908c8c1 into symfony:4.4 Aug 9, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Aug 9, 2019

feature #33078 Add compatibility trait for PHPUnit constraint classes…
… (alcaeus)

This PR was merged into the 4.4 branch.

Discussion
----------

Add compatibility trait for PHPUnit constraint classes

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Similar to the SetUpTearDownTrait, this trait removes the pain of dealing with method signature changes. The `PHPUnit\Framework\Constraint\Constraint` class added return type hints in PHPUnit 7 which this trait will take care of.

Commits
-------

908c8c1 Add compatibility trait for PHPUnit constraint classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.