Add compatibility trait for PHPUnit constraint classes #33078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
phpunit-bridge-add-constraint-compat-layer
branch
from
183fa26
to
908c8c1
Compare
nicolas-grekas
approved these changes
Aug 9, 2019
seriquynh
approved these changes
Aug 9, 2019
fabpot
approved these changes
Aug 9, 2019
|
Thank you @alcaeus. |
fabpot
added a commit
that referenced
this pull request
Aug 9, 2019
… (alcaeus) This PR was merged into the 4.4 branch. Discussion ---------- Add compatibility trait for PHPUnit constraint classes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Similar to the SetUpTearDownTrait, this trait removes the pain of dealing with method signature changes. The `PHPUnit\Framework\Constraint\Constraint` class added return type hints in PHPUnit 7 which this trait will take care of. Commits ------- 908c8c1 Add compatibility trait for PHPUnit constraint classes
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the SetUpTearDownTrait, this trait removes the pain of dealing with method signature changes. The
PHPUnit\Framework\Constraint\Constraintclass added return type hints in PHPUnit 7 which this trait will take care of.