[DomCrawler] Added Crawler::matches(), ::closest(), ::outerHtml() #33144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Aug 13, 2019
•
lyrixx
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18609 |
| License | MIT |
| Doc PR | symfony/symfony-docs#12225 |
lyrixx
changed the title
lyrixx
force-pushed
the
crawler-new-methods
branch
2 times, most recently
from
c1e593c
to
ed3be08
Compare
fabpot
requested changes
Aug 13, 2019
ismail1432
reviewed
Aug 14, 2019
lyrixx
changed the title
|
I have rebased and addressed your comments. Thanks |
lyrixx
force-pushed
the
crawler-new-methods
branch
from
ed3be08
to
9535f9e
Compare
fabpot
approved these changes
Aug 22, 2019
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Aug 22, 2019
…outerHtml() (lyrixx) This PR was merged into the 4.4 branch. Discussion ---------- [DomCrawler] Added Crawler::matches(), ::closest(), ::outerHtml() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18609 | License | MIT | Doc PR | - Commits ------- 9535f9e [DomCrawler] Added Crawler::matches(), ::closest(), ::outerHtml()
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.