Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DomCrawler] Added Crawler::matches(), ::closest(), ::outerHtml() #33144

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@lyrixx
Copy link
Member

commented Aug 13, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18609
License MIT
Doc PR symfony/symfony-docs#12225

@lyrixx lyrixx changed the title [DomCrawler] Added Crawler::matches(), ::closes() [DomCrawler] Added Crawler::matches(), ::closest() Aug 13, 2019

@lyrixx lyrixx force-pushed the lyrixx:crawler-new-methods branch 2 times, most recently from c1e593c to ed3be08 Aug 13, 2019

src/Symfony/Component/DomCrawler/Crawler.php Outdated Show resolved Hide resolved

@lyrixx lyrixx changed the title [DomCrawler] Added Crawler::matches(), ::closest() [DomCrawler] Added Crawler::matches(), ::closest(), ::outerHtml() Aug 14, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Aug 14, 2019

@fabpot

fabpot approved these changes Aug 21, 2019

Copy link
Member

left a comment

Left 2 minor comments

src/Symfony/Component/DomCrawler/Crawler.php Outdated Show resolved Hide resolved
@lyrixx

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

I have rebased and addressed your comments. Thanks

@lyrixx lyrixx force-pushed the lyrixx:crawler-new-methods branch from ed3be08 to 9535f9e Aug 22, 2019

@fabpot

fabpot approved these changes Aug 22, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Thank you @lyrixx.

fabpot added a commit that referenced this pull request Aug 22, 2019

feature #33144 [DomCrawler] Added Crawler::matches(), ::closest(), ::…
…outerHtml() (lyrixx)

This PR was merged into the 4.4 branch.

Discussion
----------

[DomCrawler] Added Crawler::matches(), ::closest(), ::outerHtml()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18609
| License       | MIT
| Doc PR        | -

Commits
-------

9535f9e [DomCrawler] Added Crawler::matches(), ::closest(), ::outerHtml()

@fabpot fabpot merged commit 9535f9e into symfony:4.4 Aug 22, 2019

0 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@lyrixx lyrixx deleted the lyrixx:crawler-new-methods branch Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.