[Console] Added suggest on bad command name #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $message = sprintf('Command "%s" is not defined.', $name); | ||
|
|
||
| if ($alternatives = $this->findAlternativeCommands($searchName)) { | ||
| $message .= PHP_EOL.'Did you mean one of these?'.PHP_EOL.' '; |
There was a problem hiding this comment.
There is no need to use PHP_EOL here (\n is fine).
|
I think we need it to also work on namespace before merging. Is it possible? |
|
could maybe use similar_text ? |
|
Yes. |
|
I added code for namespace @henrikbjorn I did the same logic as in twig. |
|
Note : Travis tests failed : http://travis-ci.org/#!/lyrixx/symfony/builds/663216 But tests are OK on my laptop |
|
Well, it may be due to github issues during the setup of the vendors. There is some issues regularly because of the DDoS attack. |
|
Yes, i guessed it :-) that's why i notice it work on my laptop |
|
This code won't work if you use abbreviations instead of the full namespace or command name. |
|
I added code to manage abbreviations. But I'm not sure what you are expecting. Can you try it and give me some feedback ? P.S. : Travis failed again, but tests pass on my laptop. |
fabpot
added a commit
that referenced
this pull request
Feb 14, 2012
Commits ------- e5edf5a [Console] Fixed CS 8abf506 [Console] Added abbreviation into search for bad command / namespace c6203bc [Console] Added namespace suggest on bad namespace name 117359a [Console] fixed CS according to PR comment dd0d97e [Console] Added suggest on bad command name Discussion ---------- [Console] Added suggest on bad command name Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: namespace ? Added something like in `git` : if user type a wrong command and if a close alternative exists, Command compenent will display a list of similar command(s). Note : It does not work with namespace. If this PR will be merged, I could work on namespace. see : https://github.com/fabpot/Twig/blob/master/lib/Twig/Environment.php#L1003 --------------------------------------------------------------------------- by fabpot at 2012-02-11T18:54:49Z I think we need it to also work on namespace before merging. Is it possible? --------------------------------------------------------------------------- by henrikbjorn at 2012-02-11T19:01:06Z could maybe use similar_text ? --------------------------------------------------------------------------- by lyrixx at 2012-02-11T19:01:55Z Yes. I will work on it asap --------------------------------------------------------------------------- by lyrixx at 2012-02-11T20:06:43Z I added code for namespace @henrikbjorn I did the same logic as in twig. --------------------------------------------------------------------------- by lyrixx at 2012-02-11T20:27:48Z Note : Travis tests failed : http://travis-ci.org/#!/lyrixx/symfony/builds/663216 ```before_script: Execution of 'php vendors.php' took longer than 600 seconds and was terminated. Consider rewriting your stuff in AssemblyScript, we've heard it handles Web Scale™``` But tests are OK on my laptop --------------------------------------------------------------------------- by stof at 2012-02-11T20:41:15Z Well, it may be due to github issues during the setup of the vendors. There is some issues regularly because of the DDoS attack. --------------------------------------------------------------------------- by lyrixx at 2012-02-11T20:58:07Z Yes, i guessed it :-) that's why i notice it work on my laptop --------------------------------------------------------------------------- by fabpot at 2012-02-11T23:11:08Z This code won't work if you use abbreviations instead of the full namespace or command name. --------------------------------------------------------------------------- by lyrixx at 2012-02-12T23:30:04Z I added code to manage abbreviations. But I'm not sure what you are expecting. Can you try it and give me some feedback ? P.S. : Travis failed again, but tests pass on my laptop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: namespace ?
Added something like in
git: if user type a wrong command and if a close alternative exists, Command compenent will display a list of similar command(s).Note : It does not work with namespace. If this PR will be merged, I could work on namespace.
see : https://github.com/fabpot/Twig/blob/master/lib/Twig/Environment.php#L1003