Fix missing exporter in PHPUnit constraint poylfill #33253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 20, 2019
alcaeus
force-pushed
the
fix-missing-exporter
branch
from
5f84631
to
b78c5cb
Compare
|
Thank you @alcaeus. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 20, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Fix missing exporter in PHPUnit constraint poylfill | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | - Since PHPUnit 7 drops the constructor in `PHPUnit\Framework\Constraint\Constraint`, overriding the constructor in a user land constraint breaks. To do so, we create an exporter in `exporter()` as is done in PHPUnit > 7. Commits ------- b78c5cb Fix missing exporter in PHPUnit constraint poylfill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHPUnit 7 drops the constructor in
PHPUnit\Framework\Constraint\Constraint, overriding the constructor in a user land constraint breaks. To do so, we create an exporter inexporter()as is done in PHPUnit > 7.