[PhpUnitBridge] Bump SYMFONY_PHPUNIT_VERSION #33318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Aug 25, 2019
fabpot
approved these changes
Aug 25, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Aug 25, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Bump SYMFONY_PHPUNIT_VERSION | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> :wave: here we are again :) i was wondering... cant we just install the latest minor by default, thus `SYMFONY_PHPUNIT_VERSION=8`? There should be no BC breaks, and would reduce the maintenance to one major bump, once a year ... isnt it? :thinking: Commits ------- 9cbd0e8 [PhpUnitBridge] Bump SYMFONY_PHPUNIT_VERSION
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 26, 2019
This PR was merged into the 4.4 branch. Discussion ---------- bump simple-phpunit see symfony/symfony#33318 Commits ------- 6e256f6 Update phpunit_bridge.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 here we are again :)
i was wondering... cant we just install the latest minor by default, thus
SYMFONY_PHPUNIT_VERSION=8? There should be no BC breaks, and would reduce the maintenance to one major bump, once a year ... isnt it? 馃