[HttpClient] fix support for 103 Early Hints and other informational status codes #33391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
hc-informational
branch
from
84782e2
to
4ccf132
Compare
dunglas
reviewed
Aug 30, 2019
ntzm
reviewed
Aug 30, 2019
nicolas-grekas
force-pushed
the
hc-informational
branch
from
4ccf132
to
60f771b
Compare
derrabus
reviewed
Aug 30, 2019
nicolas-grekas
force-pushed
the
hc-informational
branch
2 times, most recently
from
0a9982c
to
fb08681
Compare
yceruto
approved these changes
Aug 31, 2019
nicolas-grekas
force-pushed
the
hc-informational
branch
3 times, most recently
from
cc9a012
to
96bdf08
Compare
nicolas-grekas
force-pushed
the
hc-informational
branch
from
96bdf08
to
34275bb
Compare
dunglas
approved these changes
Sep 3, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Sep 3, 2019
…ormational status codes (nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] fix support for 103 Early Hints and other informational status codes | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I learned quite recently how 1xx status codes work in HTTP 1.1 when I discovered the [103 Early Hint](https://evertpot.com/http/103-early-hints) status code from [RFC8297](https://tools.ietf.org/html/rfc8297) This PR fixes support for them by adding a new `getInformationalStatus()` method on `ChunkInterface`. This means that you can now know about 1xx status code by using the `$client->stream()` method: ```php $response = $client->request('GET', '...'); foreach ($client->stream($response) as $chunk) { [$code, $headers] = $chunk->getInformationalStatus(); if (103 === $code) { // $headers['link'] contains the early hints defined in RFC8297 } // ... } ``` Commits ------- 34275bb [HttpClient] fix support for 103 Early Hints and other informational status codes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I learned quite recently how 1xx status codes work in HTTP 1.1 when I discovered the 103 Early Hint status code from RFC8297
This PR fixes support for them by adding a new
getInformationalStatus()method onChunkInterface. This means that you can now know about 1xx status code by using the$client->stream()method: