Dirname simplification #33527
Merged
Dirname simplification #33527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Sep 10, 2019
fabpot
commented
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
fabpot
requested review from
dunglas,
lyrixx,
sroze and
xabbuh
as code owners
fabpot
force-pushed
the
dirname-simplification
branch
from
b1fd6eb
to
172de43
Compare
nicolas-grekas
approved these changes
Sep 10, 2019
|
/cc @kalessil :) |
|
Awesome! |
phansys
approved these changes
Sep 10, 2019
stof
approved these changes
Sep 10, 2019
xabbuh
approved these changes
Sep 10, 2019
|
Can we add the |
fabpot
force-pushed
the
dirname-simplification
branch
from
172de43
to
c4d44eb
Compare
|
@derrabus done! |
fabpot
added a commit
that referenced
this pull request
Sep 10, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Dirname simplification | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- c4d44eb Simplify usage of dirname()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.