Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirname simplification #33527

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@fabpot
Copy link
Member

commented Sep 10, 2019

Q A
Branch? 4.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@fabpot fabpot requested review from dunglas, lyrixx, sroze and xabbuh as code owners Sep 10, 2019

@fabpot fabpot force-pushed the fabpot:dirname-simplification branch from b1fd6eb to 172de43 Sep 10, 2019

@fabpot fabpot added this to the 4.3 milestone Sep 10, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/cc @kalessil :)

@kalessil

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Awesome!

@stof
stof approved these changes Sep 10, 2019
@xabbuh
xabbuh approved these changes Sep 10, 2019
@derrabus

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Can we add the combine_nested_dirname rule to the CS Fixer ruleset?

@fabpot fabpot force-pushed the fabpot:dirname-simplification branch from 172de43 to c4d44eb Sep 10, 2019

@fabpot

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

@derrabus done!

fabpot added a commit that referenced this pull request Sep 10, 2019
minor #33527 Dirname simplification (fabpot)
This PR was merged into the 4.3 branch.

Discussion
----------

Dirname simplification

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

c4d44eb Simplify usage of dirname()

@fabpot fabpot merged commit c4d44eb into symfony:4.3 Sep 10, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

@fabpot fabpot deleted the fabpot:dirname-simplification branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.