[Serializer] Remove XmlEncoder::TYPE_CASE_ATTRIBUTES constant #33788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierredup
changed the title
|
One possibility for 4.4 is to have both constants and mark the old one with |
|
Deprecation added in #33789 |
fabpot
added a commit
that referenced
this pull request
Oct 1, 2019
…BUTES constant (pierredup) This PR was merged into the 4.4 branch. Discussion ---------- [Serializer] Deprecate the XmlEncoder::TYPE_CASE_ATTRIBUTES constant | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | yes | Tickets | N/A | License | MIT | Doc PR | N/A | Related | #33788 Deprecate the `XmlEncoder::TYPE_CASE_ATTRIBUTES` constant in favour of `XmlEncoder::TYPE_CAST_ATTRIBUTES` Commits ------- 9f51cf4 Deprecate the XmlEncoder::TYPE_CASE_ATTRIBUTES constant
pierredup
force-pushed
the
const-name-fix
branch
from
4938d66
to
ca507a9
Compare
pierredup
changed the title
pierredup
force-pushed
the
const-name-fix
branch
from
ca507a9
to
001d0f1
Compare
nicolas-grekas
approved these changes
Oct 2, 2019
|
Thank you @pierredup. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2019
…stant (pierredup) This PR was merged into the 5.0-dev branch. Discussion ---------- [Serializer] Remove XmlEncoder::TYPE_CASE_ATTRIBUTES constant | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | not really | Deprecations? | yes (well, sort of) | Tickets | N/A | License | MIT | Doc PR | N/A There is a small typo in the `XmlEncoder` constant. This can only be fixed in the master branch for Symfony 5 as it is a breaking change. I'm not sure if it's possible to deprecate the usage of the old constant name in 4.4? As the constant just resolves to a string, there is no way of determining if someone used the constant or not (a quick search on Github, I can't find any direct usages of the constant outside of this class) Commits ------- 001d0f1 Remove XmlEncoder::TYPE_CASE_ATTRIBUTES constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small typo in the
XmlEncoderconstant. This can only be fixed in the master branch for Symfony 5 as it is a breaking change. I'm not sure if it's possible to deprecate the usage of the old constant name in 4.4? As the constant just resolves to a string, there is no way of determining if someone used the constant or not (a quick search on Github, I can't find any direct usages of the constant outside of this class)