Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dotenv] allow LF in single-quoted strings #34023

Merged
merged 1 commit into from Oct 18, 2019
Merged

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 18, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

in a shell:

FOO='bar
baz'

is legal to set a value to (in PHP):

"bar\nbaz"
@stof
stof approved these changes Oct 18, 2019
@fabpot
fabpot approved these changes Oct 18, 2019
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Oct 18, 2019

Thank you @nicolas-grekas.

fabpot added a commit that referenced this pull request Oct 18, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Dotenv] allow LF in single-quoted strings

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

in a shell:
```sh
FOO='bar
baz'
```

is legal to set a value to (in PHP):
```php
"bar\nbaz"
```

Commits
-------

4d79116 [Dotenv] allow LF in single-quoted strings
@fabpot fabpot merged commit 4d79116 into symfony:3.4 Oct 18, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:de-lf branch Oct 18, 2019
This was referenced Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.