Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] fix handling of 3xx with no Location header - ignore Content-Length when no body is expected #34154

Merged
merged 1 commit into from Oct 28, 2019

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Oct 28, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

A 304 is the final response code.
This PR implements the same logic as curl.

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Oct 28, 2019
nicolas-grekas added a commit that referenced this pull request Oct 28, 2019
… ignore Content-Length when no body is expected (nicolas-grekas)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] fix handling of 3xx with no Location header - ignore Content-Length when no body is expected

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

A `304` is the final response code.
This PR implements the same logic as curl.

Commits
-------

50a88c5 [HttpClient] fix handling of 3xx with no Location header - ignore Content-Length when no body is expected
@nicolas-grekas nicolas-grekas merged commit 50a88c5 into symfony:4.3 Oct 28, 2019
@nicolas-grekas nicolas-grekas deleted the hc-304 branch October 28, 2019 16:55
@fabpot fabpot mentioned this pull request Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants