Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Dont cache classes with missing parents #34282

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 7, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Closes #34239
License MIT
Doc PR -
@stof
stof approved these changes Nov 7, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-reflcache branch from 38726d8 to e1924f9 Nov 7, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Nov 7, 2019

Now with a slightly better error message triggered from Config.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-reflcache branch from e1924f9 to 1606430 Nov 8, 2019
nicolas-grekas added a commit that referenced this pull request Nov 8, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Dont cache classes with missing parents

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Closes #34239
| License       | MIT
| Doc PR        | -

Commits
-------

1606430 [DI] Dont cache classes with missing parents
@nicolas-grekas nicolas-grekas merged commit 1606430 into symfony:3.4 Nov 8, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-reflcache branch Nov 8, 2019
This was referenced Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.