[ErrorHandler] merge and remove the ErrorRenderer component #34312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
requested review from
dunglas,
sroze and
yceruto
as code owners
nicolas-grekas
force-pushed
the
eh-vd
branch
from
d1e9c16
to
6c9157b
Compare
yceruto
reviewed
Nov 10, 2019
| /* | ||
| * This Request mimics the parameters set by | ||
| * \Symfony\Component\HttpKernel\EventListener\ErrorListener::duplicateRequest, with | ||
| * the additional "showException" flag. | ||
| */ | ||
| $subRequest = $request->duplicate(null, null, [ | ||
| '_controller' => $this->controller, | ||
| 'exception' => $exception, | ||
| 'exception' => new HttpException($code, 'This is a sample exception.'), | ||
| 'logger' => null, | ||
| 'showException' => false, |
There was a problem hiding this comment.
We are missing this attribute to show the non-debug version of the response (useful to test custom Twig-based HTML error pages) on e.g. /__error/404.html.
There was a problem hiding this comment.
However, I'm not sure it's useful for non-HTML formats.
There was a problem hiding this comment.
I'll let you follow up on this topic after merge if you don't mind.
yceruto
reviewed
Nov 10, 2019
yceruto
reviewed
Nov 10, 2019
nicolas-grekas
force-pushed
the
eh-vd
branch
2 times, most recently
from
e900eea
to
7f7312f
Compare
chalasr
reviewed
Nov 11, 2019
nicolas-grekas
force-pushed
the
eh-vd
branch
8 times, most recently
from
b2d6471
to
d3a7481
Compare
dunglas
reviewed
Nov 11, 2019
src/Symfony/Component/ErrorHandler/Resources/views/exception_full.html.php
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
eh-vd
branch
from
d3a7481
to
1a975d1
Compare
yceruto
reviewed
Nov 11, 2019
| public static function getSubscribedEvents() | ||
| { | ||
| return [ | ||
| KernelEvents::CONTROLLER_ARGUMENTS => 'onControllerArguments', |
There was a problem hiding this comment.
It would be much better if we could add this listener only when necessary, i.e. within the onKernelException method.
There was a problem hiding this comment.
I considered doing this but decided not: mutating the event-dispatcher at runtime is something we'd better avoid all the time. Also, this could introduce subtle order-dependent behaviors.
I think the check is specific enough for having it always enabled, with better unconditional behavior.
yceruto
approved these changes
Nov 11, 2019
nicolas-grekas
force-pushed
the
eh-vd
branch
from
1a975d1
to
d1bf1ca
Compare
fabpot
approved these changes
Nov 12, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 12, 2019
…onent (nicolas-grekas, yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [ErrorHandler] merge and remove the ErrorRenderer component | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR supersedes #34288. Here is what it does: - Merge the `ErrorRenderer` component into `ErrorHandler` - Add `ErrorRendererInterface::render(\Throwable $e): FlattenException` and refactor error renderers around it. - Add `FlattenException::setAsString()` to make the previous possible. - Add `CliErrorRenderer` to render error on the CLI too. This means `VarDumper` is now a required dependency of `ErrorHandler`. This paves the way to use it also for rendering HTML - the logic there is much more advanced than what `HtmlErrorRenderer` provides and ever should provide. - Make `BufferingLogger` map its collected logs to `error_log()` if they are not emptied before. - Remove some classes that are not needed anymore (`ErrorRenderer`, `ErrorRendererPass`, `HtmlErrorRendererInterface`) - Simplified the logic in `Debug::enable()` - nobody uses its arguments - Fix a few issues found meanwhile. With these changes, the component can be used standalone. One is now able to require only it, register it either with either `ErrorHandler::register()` or `Debug::enable()` and profit. Commits ------- d1bf1ca [ErrorHandler] help finish the PR 6c9157b [ErrorHandler] merge and remove the ErrorRenderer component
nicolas-grekas
added a commit
that referenced
this pull request
Nov 12, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [TwigBundle] Restore the preview mechanism | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - follow up #34312 Commits ------- d3f1121 [TwigBundle] Restore the preview mechanism
This was referenced Nov 12, 2019
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #34288.
Here is what it does:
ErrorRenderercomponent intoErrorHandlerErrorRendererInterface::render(\Throwable $e): FlattenExceptionand refactor error renderers around it.FlattenException::setAsString()to make the previous possible.CliErrorRendererto render error on the CLI too. This meansVarDumperis now a required dependency ofErrorHandler. This paves the way to use it also for rendering HTML - the logic there is much more advanced than whatHtmlErrorRendererprovides and ever should provide.BufferingLoggermap its collected logs toerror_log()if they are not emptied before.ErrorRenderer,ErrorRendererPass,HtmlErrorRendererInterface)Debug::enable()- nobody uses its argumentsWith these changes, the component can be used standalone. One is now able to require only it, register it either with either
ErrorHandler::register()orDebug::enable()and profit.