Allow \Throwable $previous everywhere #34332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fancyweb
commented
Nov 12, 2019
fancyweb
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
fancyweb
commented
Nov 12, 2019
| @@ -288,7 +288,7 @@ protected function stream(string $view, array $parameters = [], StreamedResponse | |||
| * | |||
| * @final | |||
| */ | |||
| protected function createNotFoundException(string $message = 'Not Found', \Exception $previous = null): NotFoundHttpException | |||
| protected function createNotFoundException(string $message = 'Not Found', \Throwable $previous = null): NotFoundHttpException | |||
There was a problem hiding this comment.
Allowed because @final.
nicolas-grekas
approved these changes
Nov 12, 2019
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 12, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Allow \Throwable $previous everywhere | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 59e044d Allow \Throwable $previous everywhere
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.