[HttpKernel] Remove the _controller since it is not a route parameter part of the URL #3437
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree but isn't it a BC break? I mean, someone may rely on |
|
This is a new 2.1 feature AFAIK so no it's not breaking anything. If _controller is deemed necessary then we should add it on the attributes, but not in the _route_params IMO. |
|
indeed, |
fabpot
added a commit
that referenced
this pull request
Feb 27, 2012
Commits ------- 09b1bd5 [HttpKernel] Remove the _controller since it is not a route parameter part of the url Discussion ---------- [HttpKernel] Remove the _controller since it is not a route parameter part of the URL There is no reason for the _controller to be there, the whole idea behind this _route_params thing was to help re-generating the current page's URL, you can easily grab the _route + _route_params and reconstruct it without having lots of garbage as query parameters like `?_controller=Foo::..` --------------------------------------------------------------------------- by fabpot at 2012-02-24T10:29:01Z I agree but isn't it a BC break? I mean, someone may rely on `_controller` in his code. --------------------------------------------------------------------------- by Seldaek at 2012-02-24T11:45:46Z This is a new 2.1 feature AFAIK so no it's not breaking anything. If _controller is deemed necessary then we should add it on the attributes, but not in the _route_params IMO. --------------------------------------------------------------------------- by stof at 2012-02-24T13:32:41Z indeed, ``_route_params`` is new in 2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason for the _controller to be there, the whole idea behind this _route_params thing was to help re-generating the current page's URL, you can easily grab the _route + _route_params and reconstruct it without having lots of garbage as query parameters like
?_controller=Foo::..