[Finder] not searching in multiple dirs with sorting #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -502,7 +502,8 @@ private function searchInDirectory($dir) | |||
| } | |||
|
|
|||
| if ($this->sort) { | |||
| $iterator = new Iterator\SortableIterator($iterator, $this->sort); | |||
| $iterator_aggregate = new Iterator\SortableIterator($iterator, $this->sort); | |||
| $iterator = $iterator_aggregate->getIterator(); | |||
There was a problem hiding this comment.
The coding standards are to use camel cased names for variables.
There was a problem hiding this comment.
coding standards fixed
fabpot
added a commit
that referenced
this pull request
Feb 24, 2012
Commits ------- 15910a0 fixed coding standards 24a3cd3 Finder - allow sorting when searching in multiple directories Discussion ---------- [Finder] not searching in multiple dirs with sorting I hit on a problem with **Finder, when using array of directories passed to ->in() together with sorting** (e.g. ->sortByName()): *Catchable Fatal Error: Argument 1 passed to AppendIterator::append() must implement interface Iterator, instance of Symfony\Component\Finder\Iterator\SortableIterator given in ......\vendor\symfony\src\Symfony\Component\Finder\Finder.php line 421* The problem is in Finder.php, line 419. When more than 1 directory is used, \AppendIterator is used to merge iterators for each directory. AppendIterator->append() accepts only objects implementing Iterator interface. But this is broken for SortableIterator, which implements IteratorAggregate and NOT Iterator. My proposed solution retrieves an Iterator from IteratorAggregate, which is later valid as an input to AppendIterator->append() (This solved the exception mentioned aboved in my testing project, not tested more.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit on a problem with Finder, when using array of directories passed to ->in() together with sorting (e.g. ->sortByName()):
Catchable Fatal Error: Argument 1 passed to AppendIterator::append() must implement interface Iterator, instance of Symfony\Component\Finder\Iterator\SortableIterator given in ......\vendor\symfony\src\Symfony\Component\Finder\Finder.php line 421
The problem is in Finder.php, line 419. When more than 1 directory is used, \AppendIterator is used to merge iterators for each directory. AppendIterator->append() accepts only objects implementing Iterator interface. But this is broken for SortableIterator, which implements IteratorAggregate and NOT Iterator.
My proposed solution retrieves an Iterator from IteratorAggregate, which is later valid as an input to AppendIterator->append()
(This solved the exception mentioned aboved in my testing project, not tested more.)