[HttpFoundation] Add an helper method to check if a request is a CORS preflight request #34391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preflight request
vincentchalamon
approved these changes
Nov 15, 2019
chalasr
approved these changes
Nov 15, 2019
|
There is no such distinction between CORS (preflight) / non-CORS Any distinction we try to make is arbitrary and contrary to the spec. |
|
@teohhanhui that’s wrong. Preflight requests are explicitly specified in the WHATWG’s CORS standard: https://fetch.spec.whatwg.org/#http-requests See also https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request |
maxhelias
approved these changes
Nov 22, 2019
| */ | ||
| public function isCorsPreflightRequest(): bool | ||
| { | ||
| return $this->isMethod('OPTIONS') && $this->headers->has('Access-Control-Request-Method'); |
There was a problem hiding this comment.
would it make sense to also check for Origin and Access-Control-Request-Headers?
|
Maybe the whole CORS spec should be implemented in a separate class. The Request class contains already a lot of methods and I think it becomes complex. |
|
I'm 👎 on adding yet another specific method on Request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new method to check if a request is a CORS preflight request according to the CORS spec.
It's useful in many cases (see api-platform/core#3265), and will allow to remove code from API Platform and NelmioCorsBundle.