[MonologBridge] Fix compatibility of ServerLogHandler with Monolog 2 #34697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we can prevent the BC break, it's better, isn't it? |
|
Done |
nicolas-grekas
approved these changes
Nov 29, 2019
|
I fail to see how this prevents the BC break when Monolog 2 is installed. In that case we still add the return type declaration. |
|
In Monolog 2, the interfaces If you don't ilmplement them, things won't behave as expected Your PR has a bug, as the method the BC break is coming from |
xabbuh
approved these changes
Nov 29, 2019
|
sounds reasonable 👍 |
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2019
… Monolog 2 (jderusse) This PR was merged into the 5.0 branch. Discussion ---------- [MonologBridge] Fix compatibility of ServerLogHandler with Monolog 2 | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34520 | License | MIT | Doc PR | NA This is an alternative to #34521 that keep compatibility with "processors" and "formaters". Commits ------- bdb10f7 Fix compatibility with Monolog 2
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 3, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [MonologBridge] Add test on ServerLogHandler | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | / | License | MIT | Doc PR | / After writing #34697 (comment) I realized that ServerLogHandler wasn't tested. Tell me if it's a BugFix and should be rebased on 4.3 Commits ------- 8c7947f Add test on ServerLogHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #34521 that keep compatibility with "processors" and "formaters".