Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FrameworkBundle] Use UserInterface to @return in getUser method #34723

Merged
merged 1 commit into from Dec 10, 2019
Merged

[FrameworkBundle] Use UserInterface to @return in getUser method #34723

merged 1 commit into from Dec 10, 2019

Conversation

Arman-Hosseini
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
License MIT

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 30, 2019
@Arman-Hosseini Arman-Hosseini changed the title Use UserInterface to @return in getUser method [FrameworkBundle] Use UserInterface to @return in getUser method Nov 30, 2019
nicolas-grekas
nicolas-grekas approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the discussion is for an RFC maybe, but not for 3.4, so not a blocker)

@nicolas-grekas
Copy link
Member

Thank you @Arman-Hosseini.

nicolas-grekas added a commit that referenced this pull request Dec 10, 2019
@nicolas-grekas
minor #34723 [FrameworkBundle] Use UserInterface to @return in getUse…
cd43346 
…r method (Arman-Hosseini)

This PR was squashed before being merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Use UserInterface to @return in getUser method

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

9f1ebd7 [FrameworkBundle] Use UserInterface to @return in getUser method
@nicolas-grekas nicolas-grekas merged commit 9f1ebd7 into symfony:3.4 Dec 10, 2019
@xabbuh xabbuh mentioned this pull request Dec 10, 2019
Closed
@Arman-Hosseini Arman-Hosseini deleted the patch-6 branch December 10, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ro0NL ro0NL ro0NL left review comments

@xabbuh xabbuh xabbuh approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@darielopper darielopper darielopper approved these changes

Assignees
No one assigned
Labels
FrameworkBundle Security Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Arman-Hosseini @nicolas-grekas @ro0NL @xabbuh @darielopper @carsonbot